vy commented on PR #2887: URL: https://github.com/apache/logging-log4j2/pull/2887#issuecomment-2309950654
Together with this PR, we will have 3 plugin descriptor formats: 1. The Log4j 2 `Log4j2Plugins.dat` format 2. The Newline-separated Log4j 2 `Log4j2Plugins.dat` format (introduced by this PR) 3. Log4j 3 `ServiceLoader`s Can we instead backport `ServiceLoader`s to `2.x` and be done with just two? I understand the temptation for this easy fix and I am aware that backporting `ServiceLoader`s from `3.x` to `2.x` is non-trivial. That said, when it comes to the motivation for this new plugin descriptor file format: - I don't see a pressing need (users are doing okay with the present tooling) - Shading is a bad practice anyway -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
