vy commented on code in PR #190:
URL: https://github.com/apache/logging-log4net/pull/190#discussion_r1777215772


##########
src/site/xdoc/release/release-review-instructions.xml:
##########


Review Comment:
   Given Log4Net primarily targets Windows users, I think we should cater for 
them in the instructions. For instance, `umask`, `wget`, `cd $_`, `sha512sum`, 
`for sigFile ...`, etc. don't work in Windows. I suggest
   
   - Separating Windows- and Linux-specific instructions
   - Rewriting Windows-specific instructions
   
   **An alternative route** can be to start with a warning telling Windows 
users to install bash/cygwin/subsystem/etc. to be able to run following Linux 
commands.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to