JWT007 opened a new issue, #3086:
URL: https://github.com/apache/logging-log4j2/issues/3086

   In the Log4j 2.x documentation for the RegexFilter:
   
   https://logging.apache.org/log4j/2.x/manual/filters.html#RegexFilter
   
   The only two configuration attributes are "regex" and "useRawMsg" (and the 
common filter attributes onMatch/onMismatch).
   
   In the RegExFilter @PluginFactory there is a nested element for a set of 
Strings which is not mentioned in the documentation:
   
   ```
   @PluginFactory
       public static RegexFilter createFilter(
               // @formatter:off
               @PluginAttribute("regex") final String regex,
               @PluginElement("PatternFlags") final String[] patternFlags,
               @PluginAttribute("useRawMsg") final Boolean useRawMsg,
               @PluginAttribute("onMatch") final Result match,
               @PluginAttribute("onMismatch") final Result mismatch)
               // @formatter:on
               throws IllegalArgumentException, IllegalAccessException {
   ```
   
   If I understand correctly one can provide field names from the Pattern class 
here: (CASE_INSENSITIVE, COMMENTS, etc.).
   
   The example in the Plugin Reference for the RegexFilter shows an example of 
nested strings but is not very clear with "a-String-implementation":
   
   ```
   <RegexFilter onMatch=""
                onMismatch=""
                regex=""
                useRawMsg="">
       <a-String-implementation/><!-- multiple occurrences allowed -->
   </RegexFilter>
   ```
   
   Is it:
   
   ```
   <RegexFilter ...>
     <CASE_INSENSITIVE>
     <COMMENTS>
   </RegexFilter>
   ```
   
   which the plugin reference implies.
   
   Or:
   
   ```
   <RegExFilter ...>
     <PatternFlags>CASE_INSENTIVE, COMMENTS</PatternFlags>
   </RegExFilter>
   ```
   ?
   
   A usage  example would be helpful.
   
   Maybe this API is not really "public"? In the log4j-core-test RegexFilter 
test it seems the RegexFilter is never tested with anything but a null value 
for the patternFlags.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to