rgoers commented on code in PR #134:
URL:
https://github.com/apache/logging-log4j-transform/pull/134#discussion_r1801835942
##########
log4j-transform-maven-plugin/src/main/java/org/apache/logging/log4j/transform/maven/LocationMojo.java:
##########
@@ -189,11 +192,17 @@ private WrappedIOException(IOException cause) {
}
}
- private void validateLog4jVersion() throws MojoExecutionException {
- Artifact log4jApi = project.getArtifacts().stream()
+ private boolean validateLog4jVersion() throws MojoExecutionException {
Review Comment:
I am not sure I understand. This will still throw an exception if the log4j
version is wrong. Why wouldn't you want that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
