martin-dorey-hv opened a new pull request, #3092:
URL: https://github.com/apache/logging-log4j2/pull/3092

   Fixes #3078
   
   Attempting to do as requested in 
https://github.com/apache/logging-log4j2/issues/3078#issuecomment-2413258884 
for @ppkarwasz.
   
   > ## Checklist
   
   Just excuses here, I'm afraid:
   
   > Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` 
otherwise
   
   I don't know what I'm doing wrt branches, here or otherwise, I'm afraid.
   
   > `./mvnw verify` succeeds (if it fails due to code formatting issues 
reported by Spotless, simply run `./mvnw spotless:apply` and retry)
   
   Java 17 would be tricky.
   
   > Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` 
directory
   
   I'm hoping it's regarded as trivial.
   
   > Tests for the changes are provided
   
   Yeah, I didn't do that, but apparently the examples aren't tested, so that's 
not a regression.
   
   > [Commits are 
signed](https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits)
 (optional, but highly recommended)
   
   I don't have that set up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to