ppkarwasz commented on code in PR #3085:
URL: https://github.com/apache/logging-log4j2/pull/3085#discussion_r1802454822
##########
log4j-1.2-api/src/test/java/org/apache/log4j/LevelTest.java:
##########
@@ -205,6 +207,70 @@ public void testALL() {
assertTrue(Level.ALL instanceof Level);
}
+ /**
+ * Tests Level.OFF version2Level.
+ */
+ @Test
+ public void testOffVersion2Level() {
+ assertEquals(org.apache.logging.log4j.Level.OFF,
Level.OFF.getVersion2Level());
+ }
+
+ /**
+ * Tests Level.FATAL version2Level.
+ */
+ @Test
+ public void testFatalVersion2Level() {
+ assertEquals(org.apache.logging.log4j.Level.FATAL,
Level.FATAL.getVersion2Level());
+ }
Review Comment:
The test class uses unfortunately JUnit 4, but it should be easy to convert
it to a JUnit 5 test class with a `@ParameterizedTest` instead of multiple
single tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
