JWT007 commented on issue #2769:
URL:
https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2461681124
Hi @ppkarwasz hmmm I am not sure - what is the real impact?
How many really create the SocketPerformancePreferences programmatically?
:/
I think *if* someone is creating a SocketPerformancePreferences
programmatically they are doing it like this:
```
SocketPerformancePreferences socketPerformancePreferences =
SocketPerformancePreferences.newBuilder();
socketPerformancePreferences .setBandwidth(200);
socketPerformancePreferences .setConnectionTime(50);
socketPerformancePreferences.setLatency(5);
SocketPerformancePreferences clonedSPP =
socketPerformancePreferences.build();
```
In this case changing the return type would not really be a breaking-change
because no one is currently *expecting* a return type.
The only difference would be that one *could* chain the commands after the
change:
```
SocketPerformancePreferences socketPerformancePreferences =
SocketPerformancePreferences
.newBuilder()
.setBandwidth(200)
.setConnectionTime(50)
.setLatency(5)
.build();
```
Worse would be going from a return type to void. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
