ppkarwasz commented on issue #3172: URL: https://github.com/apache/logging-log4j2/issues/3172#issuecomment-2469764544
> I am not sure why the bot didn't mark this as "waiting for maintainer" - not sure if it pops up for you? The workflow is in [`labeler.yaml`](https://github.com/apache/logging-log4j2/blob/2.x/.github/workflows/labeler.yaml) and is based on the affiliation of the reporter with the organization/repository/issue. I am not sure how GitHub assigns them. IIRC I had to add `CONTRIBUTOR` to the list, since some maintainers didn't show up as `MEMBER`. If you know a better way to check if the issue author has write permission to the repo, feel free to submit a PR. > If however, two configurations had an `AsyncWaitStrategyFactory` element: Personally I think that the `AsyncWaitStrategyFactory` needlessly complicates the configuration. There is a [`log4j2.asyncLoggerConfigWaitStrategy`](https://logging.apache.org/log4j/2.x/manual/systemproperties.html#log4j2.asyncLoggerConfigWaitStrategy) Log4j configuration property with a similar purpose. Anyway, except `<Properties>`, `<Appenders>`, `<Loggers>`, `<Scripts>` and filters, all the other **direct** children of `<Configuration>` should replace the children of the same type IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
