ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-2472799453
> > We will apply the rule as a one off operation. > > Yeah, so run the rule locally, and just not add dependency file changes in the commit? I would say that implementing such a change should consist of several steps: 1. The source code of the OpenRewrite rule should be published. If not in OpenRewrite itself, at least in [Log4j Tools](https://logging.apache.org/log4j/tools/). 2. You create a PR with **two** commits. - In the first commit you add a `rewrite.yml` file to the repo and update the `rewrite` profile in the [main `pom.xml`](https://github.com/apache/logging-log4j2/blob/cab5454e201de95817600e79a26235c72e65d195/pom.xml#L1042-L1076). We did have a `rewrite.yml` file in the past, you can take [the last version](https://github.com/apache/logging-log4j2/blob/5c54d1f8470e039c0836a50aa496b05a49148b91/rewrite.yml) and add your rule below. - In the second commit you just add the modifications generated by `./mvnw -Prewrite`. Such a procedure would help reviewing the PR. A reviewer can just pull your first commit and verify that the second commit contains only changes generated by OpenRewrite. Changes generated by OpenRewrite are **massive** and we need to show the world that PRs are reviewed with due diligence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
