ppkarwasz commented on code in PR #3209:
URL: https://github.com/apache/logging-log4j2/pull/3209#discussion_r1846308278
##########
log4j-api/src/main/java/org/apache/logging/log4j/spi/LoggerRegistry.java:
##########
@@ -243,32 +232,30 @@ public boolean hasLogger(final String name, final Class<?
extends MessageFactory
* Registers the provided logger.
* <b>Logger name and message factory parameters are ignored</b>, those
will be obtained from the logger instead.
*
- * @param name ignored – kept for backward compatibility
- * @param messageFactory ignored – kept for backward compatibility
+ * @param name a logger name
Review Comment:
What about registering a logger using both the coordinates provided by the
caller of `putIfAbsent` and those inferred from the `Logger` instance? See
https://github.com/apache/logging-log4j2/pull/3209/commits/2f1065d331af9d4df351d0fe41af80b49041e2b2
As far as I am concerned, the only valid reason for mismatching message
factories might be provided by the proposed "metrics extension" (#2469)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
