jaykataria1111 commented on code in PR #3195: URL: https://github.com/apache/logging-log4j2/pull/3195#discussion_r1862956639
########## log4j-core/src/main/java/org/apache/logging/log4j/core/config/plugins/processor/PluginProcessor.java: ########## @@ -39,14 +41,20 @@ import javax.lang.model.SourceVersion; import javax.lang.model.element.Element; import javax.lang.model.element.ElementVisitor; +import javax.lang.model.element.ExecutableElement; +import javax.lang.model.element.Modifier; import javax.lang.model.element.TypeElement; +import javax.lang.model.element.VariableElement; import javax.lang.model.util.Elements; import javax.lang.model.util.SimpleElementVisitor7; +import javax.lang.model.util.Types; import javax.tools.Diagnostic; import javax.tools.FileObject; import javax.tools.StandardLocation; +import org.apache.commons.lang3.StringUtils; Review Comment: I see, yeah log4j is pretty bottom stack, we should be minimizing dependencies, thanks a lot @ppkarwasz for finding this out! I am sorry that you had to struggle for this. I have corrected it now :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
