JWT007 opened a new issue, #3472:
URL: https://github.com/apache/logging-log4j2/issues/3472
Log4j 2.24.3
--------
A `KeyValuePair` without a key is useless (since it cannot be referenced).
A `null` key will also cause problems in multiple locations when added to Map
implementations.
Theoretically the same is true of the value but the null cases seem to all
be handled when working with KVPs.
The `KeyValuePair` provides no validation / required on the
`@PluginAttribute` or in the builder.
In addition, the `DefaultKeyValuePairComponentBuilder` sets the atttributes
on the component builder without validating whether they are null.
If the builder is used to generate XML this results in null attributes which
will break parsing that XML.
```
public DefaultKeyValuePairComponentBuilder(
final DefaultConfigurationBuilder<? extends Configuration>
builder, final String key, final String value) {
super(builder, "KeyValuePair");
addAttribute("key", key);
addAttribute("value", value);
}
```
This constructor should probably throw an NPE or IllegalArgumentException if
the key is `null` and only add the value attribute if it is *not* `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
