ppkarwasz commented on issue #3478:
URL:
https://github.com/apache/logging-log4j2/issues/3478#issuecomment-2675012781
> Its probably OK then - was just expecting the PropertyComponentBuilder to
generate as documented.
Since XML elements can have attributes, nested elements and text content,
the XML configuration format offers some flexibility on how to specify
configuration attributes. In our manual we try to use a "canonical" form, but
it is not always consistent.
Two Log4j plugins can have text content: `<Property>` and `<Script>`. For
the first, we use an attribute in the examples:
```xml
<Property name="foo" value="bar"/>
```
but for the second we use a CDATA node:
```xml
<Script name="EVENT_LOGGER_FILTER" language="groovy"><![CDATA[
return logEvent.getMarker() != null &&
logEvent.getMarker().isInstanceOf("FLOW");
]]></Script>
```
However, this is a personal style choice, I am not sure if we should align
`DefaultConfigurationBuilder` to it or even if there is a consensus on the
style. I am +0 on such a change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
