ppkarwasz commented on PR #3258: URL: https://github.com/apache/logging-log4j2/pull/3258#issuecomment-2701358647
> > Should we disable BND annotations by default (for users) and keep the option for our own builds (the BND annotations are useful to generate the necessary `META-INF/services` files and similar)? > > Could you elaborate on how we can implement this? Does this also mean, there will be no need for a toggle property? What I mean is, I just replace: https://github.com/apache/logging-log4j2/blob/e6e6dddb41502edcbb89f8d23800449c142279f9/log4j-plugin-processor/src/main/java/org/apache/logging/log4j/plugin/processor/PluginProcessor.java#L318-L325 with `return false` and we add `-Alog4j.plugin.enabledBndAnnotations=true` to our builds. BND runs after `compile` and it registers the `PluginService` in the correct files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
