Re: [PR] Adjust GcpLayout JSON to latest format [logging-log4j2]

[via GitHub]

ViliusS commented on code in PR #3586:
URL: https://github.com/apache/logging-log4j2/pull/3586#discussion_r2046657811


##########
log4j-layout-template-json/src/main/resources/GcpLayout.json:
##########
@@ -49,25 +55,15 @@
     "key": "span_id"
   },
   "logging.googleapis.com/trace_sampled": true,
-  "_exception": {
-    "class": {
-      "$resolver": "exception",
-      "field": "className"
-    },
-    "message": {
-      "$resolver": "exception",
-      "field": "message"
-    },
-    "stackTrace": {
-      "$resolver": "pattern",
-      "pattern": "%xEx"
-    }
+  "exception": {
+    "$resolver": "pattern",
+    "pattern": "%xEx"
   },

Review Comment:
   @vy thank you for the detailed analysis. I have tested exception resolver 
with another exception type on Artemis and it looks like you might be right. 
The output with exception resolver during native Java's IllegalStateException:
   
![image](https://github.com/user-attachments/assets/d6916995-c75e-4c5a-9c25-5950e306c36e)
   
   I have now changed JTL to use exception resolver as requested.
   
   If there are no other issues with this PR I will then try to fix tests for 
timestamp fields.
   
   @ppkarwasz I do have access to Artemis JIRA and will send PR to add full 
package name to them shortly.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org