neboskreb commented on PR #3638: URL: https://github.com/apache/logging-log4j2/pull/3638#issuecomment-2843107311
> * Could you [add a changelog file](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file) to `src/changelog/.2.x.x`? You can use one of the files already there as template. Done > * All the commits must be signed with a GPG recognized by Github. If you didn't do it before, could you [add a GPG key to your Github account](https://docs.github.com/en/authentication/managing-commit-signature-verification/adding-a-gpg-key-to-your-github-account) and then rebase this PR, so all commits get signed? Hmmm, `git log --show-signature 40d66ed7` shows that the commit is signed but I don't see the checkmark next to it here on Github... Is this normal? If not, what can I do to rectify? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
