magicwerk commented on code in PR #3645:
URL: https://github.com/apache/logging-log4j2/pull/3645#discussion_r2074285211
##########
log4j-api-test/src/test/java/org/apache/logging/log4j/message/ParameterFormatterTest.java:
##########
@@ -183,4 +183,52 @@ void testIdentityToString() {
final String expected = list.getClass().getName() + "@" +
Integer.toHexString(System.identityHashCode(list));
assertThat(actual).isEqualTo(expected);
}
+
+ @Test
+ void testDeepToStringArrayInt() {
+ final int[] array = new int[] {0, 1, 2, 3, 4};
+ final String actual = ParameterFormatter.deepToString(array);
+ final String expected = "[0, 1, 2, 3, 4]";
+ assertThat(actual).isEqualTo(expected);
+ }
Review Comment:
I created the parameterized test testDeepToStringPrimitiveArrays.
I left the other test out as their initialization is more complex so it
would IMHO clutter the now simple code - ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
