vy commented on PR #3681: URL: https://github.com/apache/logging-log4j2/pull/3681#issuecomment-2905826164
I would like to and I will. Please allow me some time. Op vr 23 mei 2025 om 21:27 schreef Piotr P. Karwasz < ***@***.***> > ***@***.**** approved this pull request. > > The changes look solid—nice work! There's just one final task before we > can wrap this up: could you please add a changelog entry under > src/changelog/.2.x.x, as outlined in the changelog documentation > <https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file> > ? > > Also, just a quick note on loggerRefByNameByMessageFactory: since it's a > WeakHashMap, it doesn’t follow all the typical Map invariants. From what > I can tell, you're using it safely, and I didn’t spot any issues that would > lead to unexpected behavior. That said, given the sensitivity of this part > of the codebase, I’d like a second pair of eyes on it. > > @vy <https://github.com/vy>, could you take a moment to review this as > well? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/logging-log4j2/pull/3681#pullrequestreview-2865498516>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AAARTSIM67PBK326RDUMPTD275ZDDAVCNFSM6AAAAAB5TRLZL6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDQNRVGQ4TQNJRGY> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
