vy commented on code in PR #3703:
URL: https://github.com/apache/logging-log4j2/pull/3703#discussion_r2118221267
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/config/builder/api/ConfigurationBuilder.java:
##########
@@ -61,6 +61,15 @@ public interface ConfigurationBuilder<T extends
Configuration> extends Builder<T
*/
ConfigurationBuilder<T> add(CustomLevelComponentBuilder builder);
+ /**
+ * Adds a top level component.
+ * @param builder The ComponentBuilder with all of its attributes and sub
components set.
+ * @return this builder instance.
+ */
+ default ConfigurationBuilder<T> addComponent(ComponentBuilder<?> builder) {
+ throw new UnsupportedOperationException();
+ }
Review Comment:
Added the `@since` tag in 2fea3657a6507069d997ecaefc94e8e013d314d5.
> I would prefer introducing an abstract method
This is an `interface`, not an `abstract class`, do you imply not providing
any default methods at all?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
