ppkarwasz commented on PR #3759: URL: https://github.com/apache/logging-log4j2/pull/3759#issuecomment-2985504984
> I don't know but it was clearly missing in the parent pom, so maybe that got resolved instead? To expand a bit on what @vy pointed out: * The `jspecify.version` property is currently defined in the [top-level POM (`/pom.xml`)](https://github.com/apache/logging-log4j2/blob/2.x/pom.xml), which corresponds to the `log4j-bom` module. * However, since we flatten `log4j-bom` before publishing it to Maven Central, any properties defined in that POM—including `jspecify.version`—don’t make it into the published artifact. This is the root cause of the issue. So rather than just duplicating the property in `/log4j-parent/pom.xml`, I’d suggest we: * **Remove** the `jspecify.version` property from `/pom.xml`. * **Move** the configuration for the `java8-tests` profile (excluding the activator) from `/pom.xml` to `/log4j-parent/pom.xml`. This way, the property is defined at the right level (in the parent, where it will be inherited properly), and we avoid any confusion or redundancy between flattened and non-flattened modules. > ### 📝 Changelog (select one) > > * [ ] I added a changelog entry in `src/changelog/.2.x.x`. (See [Changelog Entry File Guide](https://logging.apache.org/log4j/tools/log4j-changelog.html#changelog-entry-file)). > * [x] This is a trivial change and does not require a changelog entry. I’d actually argue this isn’t a trivial change—it addresses a significant issue that breaks dependency resolution and **should** have a changelog entry. We'll likely need to cut a `2.25.1` release to fix it, so thank you for identifying the root cause! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
