FreeAndNil commented on code in PR #262:
URL: https://github.com/apache/logging-log4net/pull/262#discussion_r2182205831
##########
src/log4net/Appender/RollingFileAppender.cs:
##########
@@ -790,7 +790,7 @@ private void InitializeFromOneFile(string baseFile, string
curFileName)
curFileName = curFileName.ToLowerInvariant();
baseFile = baseFile.ToLowerInvariant();
string dir = string.IsNullOrEmpty(baseFile) ? "" :
Path.GetDirectoryName(baseFile);
- var baseFileWithoutExtension = Path.Combine(dir ?? "",
Path.GetFileNameWithoutExtension(baseFile));
+ string baseFileWithoutExtension = Path.Combine(dir ?? "",
Path.GetFileNameWithoutExtension(baseFile));
Review Comment:
Yes, I prefer `SomeType thing = new();` because you can use the same Pattern
for Lists: `List<string> list = [];`
`var list = new List<string>();` is "much" longer ;-)
Even the version for simple objects is now shorter without var. I only use
var for complex Linq-Queries or when I don't know what to expect 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
