ppkarwasz commented on issue #2769: URL: https://github.com/apache/logging-log4j2/issues/2769#issuecomment-3051462889
Hi @snicoll, > > If you’d prefer to keep it package-private, you can suppress the warning using: > > I saw the suggestion, I don't want to do that as it's reporting the problem down the road. > > I think my question is more about insisting on having the setter public, while not insisting for the class to be public. You are right, allowing package-private builders is an oversight we should fix in a followup issue. > > Let me know what you think > > Do you want me to provide feedback here? I will be following all the channels, but the official way to provide feedback on the vote e-mail is by answering the vote thread on `d...@logging.apache.org`: https://lists.apache.org/thread/yhfgs50hlwmt9hvocr47ftzd3vowvb2m This way the whole PMC can see your arguments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
