ppkarwasz commented on PR #3789: URL: https://github.com/apache/logging-log4j2/pull/3789#issuecomment-3053034368
> > @vy should I use `FixedDateFormat.FixedFormat#getPattern` in case of `InstantPatternFormatter.LEGACY_FORMATTERS_ENABLED` is `true`? > > @ashr123, no, absolutely not. They should not be used anywhere in Log4j. In `2.25.0` we put great effort into deprecating them – see [the release notes](https://logging.apache.org/log4j/2.x/release-notes.html#release-notes-2-25-0-instant-format). This ties back to my earlier comment: https://github.com/apache/logging-log4j2/pull/3789#pullrequestreview-2998821838 I don’t think `NamedInstantFormat` should replicate the legacy pattern values — they’re not useful to external users. If needed, the `decodeNamedPattern` method can still retrieve them internally, as it does in the current version of the PR: https://github.com/apache/logging-log4j2/blob/6b311cd8e81704643a6805e8703ed7325a8e3ef5/log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/DatePatternConverter.java#L142-L148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
