ppkarwasz commented on code in PR #216:
URL:
https://github.com/apache/logging-log4j-transform/pull/216#discussion_r2259768741
##########
log4j-converter-config/src/main/java/org/apache/logging/converter/config/internal/v2/AbstractJacksonConfigurationMapper.java:
##########
@@ -73,6 +73,8 @@ public void writeConfiguration(OutputStream outputStream,
ConfigurationNode conf
? nodeFactory.objectNode().set(configuration.getPluginName(),
configurationNode)
: configurationNode;
mapper.writeValue(outputStream, documentNode);
+ outputStream.write('\n');
+ outputStream.close();
Review Comment:
Since the output stream is provided by the caller, I think it is up to the
caller to close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
