ppkarwasz commented on code in PR #3868: URL: https://github.com/apache/logging-log4j2/pull/3868#discussion_r2265377992
########## log4j-api/src/main/java/org/apache/logging/log4j/CloseableThreadContext.java: ########## @@ -206,7 +207,7 @@ public void close() { } private void closeMap() { - final Map<String, String> valuesToReplace = new HashMap<>(originalValues.size()); + final Map<String, String> valuesToReplace = Maps.newHashMap(originalValues.size()); Review Comment: Can you point out an example, where the usage of `HashMap#new(int)` is inappropriate? I am mostly +1 on the proposed changes, as long as they don't introduce a new API. We have already dealt with methods and classes backported from newer JDK versions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org