vy commented on code in PR #3874: URL: https://github.com/apache/logging-log4j2/pull/3874#discussion_r2278384363
########## src/changelog/.2.x.x/3874_remove_jvmrunargs_lookup.xml: ########## @@ -0,0 +1,12 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="removed"> + <issue id="3874" link="https://github.com/apache/logging-log4j2/issues/3874"/> + <description format="asciidoc"> + Removed the `jvmrunargs` lookup and related code due to lack of clear use case and potential for confusion. Review Comment: We don't need to elaborate on our reasoning in the changelog, interested people can check the linked issue: ```suggestion Remove the `jvmrunargs` lookup ``` ########## src/changelog/.2.x.x/3874_remove_jvmrunargs_lookup.xml: ########## @@ -0,0 +1,12 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="removed"> + <issue id="3874" link="https://github.com/apache/logging-log4j2/issues/3874"/> Review Comment: ```suggestion <issue id="3874" link="https://github.com/apache/logging-log4j2/pull/3874"/> ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
