ppkarwasz commented on PR #3880: URL: https://github.com/apache/logging-log4j2/pull/3880#issuecomment-3198330250
> @vy @ppkarwasz Just to be clear, _this_ PR doesn't change the default policy to `Discard`, it changes the _default discard threshold_ when `Discard` is configured (in other words, when the user has already opted in to dropping of log events). I don't think I've seen any comments on the actual proposal here. Good point! :100: Most of the discussion so far has centered on @vy’s comment https://github.com/apache/logging-log4j2/pull/3880#issuecomment-3190784094 about changing the default to `Discard` (a Log4j “heresy”) and we lost sight of your actual changes. Regarding your PR specifically: * I’m still concerned about changing the default threshold to `ERROR`, since that would effectively stop all logging. The current default of `INFO` seems safer: it still lets `WARN` and `ERROR` through (i.e., prevents them from being discarded). With your change, when the queue is full, the status logger will emit a warning, but since its default level is `ERROR`, that warning won’t be shown. In practice, users could experience a complete logging blackout. * I also find the semantics of `log4j2.discardThreshold` a bit unintuitive. Naively, I’d expect it to mean “log events at this level or higher will be retained.” Instead, it only retains events that are strictly more severe than the configured level, which is easy to misinterpret. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
