ppkarwasz commented on PR #351:
URL:
https://github.com/apache/logging-log4j-samples/pull/351#issuecomment-3239408984
I had to hook into Gradle’s **internal logging system** to make the build
fail on warnings/errors, and it worked 🎉.
This relies on unsupported APIs, so it may break in a future Gradle major
release, but since we don’t plan to upgrade Gradle anytime soon it’s an
acceptable trade-off for now.
In fact, the CI failure here is proof that the check is working correctly:
```
* Build failed due to 1 WARN/ERROR log event(s):
Error: Errors occurred while building effective model from
/home/runner/.gradle/caches/modules-2/files-2.1/org.apache.logging.log4j/log4j-api/2.26.0-SNAPSHOT/89185e886b8a01f7bd7deadcb0dccd0fc916c7/log4j-api-2.26.0-SNAPSHOT.pom:
'dependencies.dependency.version' for
com.google.errorprone:error_prone_annotations:jar must be a valid version but
is '${error-prone.version}'. in
org.apache.logging.log4j:log4j-api:2.26.0-SNAPSHOT
```
Thanks again for your contribution, @MartyIX 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
