vy commented on PR #3901: URL: https://github.com/apache/logging-log4j2/pull/3901#issuecomment-3241226486
I think 1. **we're comparing apples with oranges**. We use ES client to test a functionality, the fact that it depends on Java 17 should not stop us from using it, in particular, given that we already use Java 17 to compile the sources. That is, we already have Java 17 at our disposal while running tests – saying _"Don't use Java 17 because our CI tests run in Java 8"_ does not make sense to me. 2. There is only one problematic test: `LogstashIT`. It is executed via `maven-failsafe-plugin` configured in the `docker` profile defined in `log4j-layout-template-json-test/pom.xml`, **it has nothing to do with `java8-tests` profile** in `log4j-parent/pom.xml`, and the latter forces Java 8. 3. Using different major versions across `2.x` and `main` will obstruct **porting process**. @ppkarwasz, what about the following plan instead? 1. Use the latest and greatest ES client on `2.x` 2. Update `maven-failsafe-plugin` in the `docker` profile in `log4j-layout-template-json-test/pom.xml` to force Java 17 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
