rm5248 commented on code in PR #539: URL: https://github.com/apache/logging-log4cxx/pull/539#discussion_r2348793323
########## src/site/markdown/performance.md: ########## @@ -65,3 +59,46 @@ The throughput tests may be built by specifying `BUILD_THROUGHPUT` with CMake when building Log4cxx. The benckmark tests require Google's [Benchmark](https://github.com/google/benchmark) library and may be built by specifying `BUILD_BENCHMARK_CHECKS` with CMake when building Log4cxx. + +The following table shows some timing tests using Google's benchmarking library. + + g++ (Ubuntu 11.4.0-1ubuntu1~22.04.2) 11.4.0 + Run on (8 X 2328.61 MHz CPU s) + CPU Caches: + L1 Data 32 KiB (x4) + L1 Instruction 32 KiB (x4) + L2 Unified 256 KiB (x4) + L3 Unified 6144 KiB (x1) + Load Average: 0.07, 0.03, 0.01 + +| Benchmark | Time | CPU | Iterations | Review Comment: some commentary on what this table is showing would be useful. For example, are some columns higher = better or lower=better? One other question I have is why is the first iteration not random digits, like the other values? Are all of the performance metrics based on how long the first one performs? Other thoughts: * Should we compare this to spdlog? * Would a graph help to show the data as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
