vy commented on code in PR #3901:
URL: https://github.com/apache/logging-log4j2/pull/3901#discussion_r2360472725


##########
log4j-layout-template-json-test/src/test/java/org/apache/logging/log4j/layout/template/json/LogstashIT.java:
##########


Review Comment:
   @ramanathan1504, why did you replace the strongly-typed client calls with 
raw JSON parsing? AFAIK, typed, say, `SearchResponse` is still supported[1]. If 
we'll perform raw HTTP-querying and deal with JSON marshalling ourselves, what 
is the point of using the ES client?
   
   [1]: 
https://www.elastic.co/docs/reference/elasticsearch/clients/java/usage/searching



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to