joepembe commented on code in PR #3934:
URL: https://github.com/apache/logging-log4j2/pull/3934#discussion_r2392940649
##########
log4j-core-test/pom.xml:
##########
@@ -347,6 +347,12 @@
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.mockito</groupId>
+ <artifactId>mockito-inline</artifactId>
+ <scope>test</scope>
+ </dependency>
+
Review Comment:
Oops! I wrote a unit test for these changes, but somehow it did not make it
into the commit that I pushed to my forked repository. Apologies - I haven't
used github much. I'll put together another revision and send it your way.
Anyways, the unit test that I wrote (and failed to include in the original
PR) depends on the ability to specify mocked behavior for
`Throwable#getSuppressed()`. Since `Throwable#getSuppressed()` is `final`,
vanilla mockito can't do this - hence I added `mockito-inline`.
This is also the reason why I had to touch a handful of otherwise-unrelated
tests beneath `log4j-core-test/`. These tests were silently depending on
mockito's _inability_ to mock `final` methods, so they required some slight
tweaking to get them to pass in the presence of `mockito-inline`.
##########
log4j-core-test/src/test/java/org/apache/logging/log4j/core/appender/db/AbstractDatabaseAppenderTest.java:
##########
Review Comment:
See other comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@logging.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
