vy commented on code in PR #3968: URL: https://github.com/apache/logging-log4j2/pull/3968#discussion_r2509475316
########## src/changelog/.2.x.x/3968_refactor_manager_factories.xml: ########## @@ -0,0 +1,12 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns" + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd" + type="changed"> + <issue id="3968" link="https://github.com/apache/logging-log4j2/pull/3968"/> + <description format="asciidoc"> + Simplify file manager registry factory methods by removing unnecessary boilerplate code. Review Comment: Shall we remove the negative expression `unnecessary boilerplate code`? ```suggestion Simplify file manager registry factory methods ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
