potiuk commented on code in PR #414: URL: https://github.com/apache/logging-log4cxx/pull/414#discussion_r2522374175
########## package.sh: ########## @@ -0,0 +1,108 @@ +#!/bin/bash +# +set -e + +# Shorthand for digit class: +d="[[:digit:]]" +# Determine the version and build timestamp +VERSION=$(sed -n -e "s/^set(log4cxx_VER \(.*\)\.$d\+)/\1/p" < src/cmake/projectVersionDetails.cmake) +if ! echo "$VERSION" | grep -Eq "^$d+\.$d+\.$d+$"; then + echo Invalid version number: "$VERSION" >& 2 + exit 1 +fi + +OUTPUT_TIMESTAMP=$(sed -n -e "s/^set(log4cxx_OUTPUT_TIMESTAMP \"\(.*\)\")/\1/p" < src/cmake/projectVersionDetails.cmake) Review Comment: What we do in airflow we keep a https://github.com/apache/airflow/blob/main/reproducible_build.yaml file like tha tin the repo and we have prek hook (pre-commit) that calculates hash of release notes and updates the file with current time every time release notes is about to be committed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
