lrozenblyum commented on code in PR #4014:
URL: https://github.com/apache/logging-log4j2/pull/4014#discussion_r2650370613
##########
log4j-api/src/main/java/org/apache/logging/log4j/message/ParameterFormatter.java:
##########
@@ -268,6 +267,12 @@ static void formatMessage(
}
}
+ private static boolean ignoreLastArgument(final Object[] args, final int
argCount) {
Review Comment:
I've applied the first suggestion (`isLastArgumentThrowable`).
Extracting a method to get arg count - haven't done that because its naming
itself is a big question :) Even the name `getArgCountWithoutLastThrowable`
would be ambiguous. Technically it should sound
`getArgCountIgnoringLastArgumentIfItIsThrowable` - yet it's too clumsy...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
