ppkarwasz commented on PR #4011: URL: https://github.com/apache/logging-log4j2/pull/4011#issuecomment-3698756024
@vy, I think delaying **when a rollover is triggered** and delaying **when the asynchronous rollover actions execute** should have separate configuration knobs. The execution of asynchronous actions lives in `RollingFileManager`, so tying that behavior to an attribute on a specific `TriggeringPolicy` (or rollover strategy) feels like a layering violation. For this PR specifically, I believe there’s a simpler and cleaner approach: instead of wrapping actions and sleeping, we could replace the `ExecutorService` in `RollingFileManager` with a `ScheduledExecutorService` and apply the delay at scheduling time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
