vy commented on code in PR #16:
URL: https://github.com/apache/logging-site/pull/16#discussion_r2655231716
##########
.github/workflows/deploy-site.yaml:
##########
@@ -43,6 +43,11 @@ jobs:
whoami: ${{ github.ref_name }}-site-stg-out
subdir: content/
target-branch: ${{ github.ref_name }}-site-stg-out
+ # For some unknown reason, `target-path` needs to be `content`.
+ # Fortunately, it is only `logging-site` that needs to implement this
hack.
+ # Other `logging-*` repositories using `deploy-site-reusable.yaml` can
continue using the default `target-path`.
+ # See https://issues.apache.org/jira/browse/INFRA-27533
+ target-path: content
Review Comment:
> It's not really unknown reasons. We can have:
>
> * Either `subdir: content/` in the `.asf.yaml` file **and** `target-path:
content`, or
> * No `subdir` in the `.asf.yaml` file **and** `target-path: .` (default).
I don't think this is the case — providing `subdir: content` with
`target-path: .` (default) works for _all_ other projects:
https://github.com/apache/logging-log4j2/blob/2.x/.github/workflows/deploy-site.yaml#L44-L50
We know this particular combination works for `logging-site` and only for
`logging-site`, but we don't know why.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
