dimitarndimitrov opened a new pull request, #4038:
URL: https://github.com/apache/logging-log4j2/pull/4038

   The docs for the AsyncLoggerConfig properties, which are relevant for mixed 
sync and async loggers, specify the wrong property name for the config that 
controls the Disruptor ring buffer size. Interestingly the right property name 
is used in the anchor ID linking to the exact section in the docs, but if you 
copy the property name from the docs themselves (like me), you are gonna have a 
bad time.
   
   I found this after noticing a too big ring buffer in a heap dump, and ended 
up chasing it with the `StatusLogger` debug logging and the log line in 
`AsyncLoggerConfigDisruptor.start` dumping the configured size. The small fix 
was also verified this way.
   
   In hindsight, this should have been obvious, but it really wasn't (for me).
   
   ## Checklist
   
   * Base your changes on `2.x` branch if you are targeting Log4j 2; use `main` 
otherwise
   * `./mvnw verify` succeeds ([the build 
instructions](https://logging.apache.org/log4j/2.x/development.html#building))
   * Non-trivial changes contain an entry file in the `src/changelog/.2.x.x` 
directory
   * Tests are provided
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to