rm5248 commented on code in PR #584:
URL: https://github.com/apache/logging-log4cxx/pull/584#discussion_r2739651954
##########
src/main/cpp/patternlayout.cpp:
##########
@@ -132,7 +132,8 @@ void PatternLayout::format(LogString& output,
converterIter != m_priv->patternConverters.end();
converterIter++, formatterIter++)
{
- int startField = (int)output.length();
+ // Fix integer truncation vulnerability (size_t to int cast)
+ size_t startField = output.length();
Review Comment:
it looks like you have some odd indentation here.
the comment is also not helpful, can we remove it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
