swebb2066 opened a new pull request, #603: URL: https://github.com/apache/logging-log4cxx/pull/603
This PR implements a number of changes to Appender interfaces in the next ABI version, including the removal of AppenderSkeleton::finalize(), which violated the [do not call virtual functions in a destructor](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#rc-ctor-virtual) recommendation. The PR replaces calls to AppenderSkeleton::finalize() with the following code pattern: ``` if (_priv->setClosed()) _priv->close(); ``` The `WriterAppender` interface is also simplified in the next ABI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
