ppkarwasz commented on code in PR #4075:
URL: https://github.com/apache/logging-log4j2/pull/4075#discussion_r2983945210


##########
log4j-core/src/main/java/org/apache/logging/log4j/core/net/ssl/SslConfiguration.java:
##########
@@ -178,15 +178,14 @@ private static TrustManager[] loadTrustManagers(@Nullable 
final TrustStoreConfig
      * @param keyStoreConfig   The KeyStoreConfiguration.
      * @param trustStoreConfig The TrustStoreConfiguration.
      * @return a new SslConfiguration
+     * @deprecated Since 2.26.0, use {@link #createSSLConfiguration(String, 
KeyStoreConfiguration, TrustStoreConfiguration, boolean)} instead.
      */
+    @Deprecated
     @NullUnmarked
-    @PluginFactory
     public static SslConfiguration createSSLConfiguration(

Review Comment:
   No need to deprecate the old method, I guess.
   
   
https://github.com/apache/logging-log4j2/pull/4075/commits/b3e07ad1789c48d535a42ab699d4687c98a8a57f



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to