metsw24-max opened a new pull request, #672:
URL: https://github.com/apache/logging-log4cxx/pull/672

   Strip CR/LF characters from SMTPAppender Subject and address-related fields 
to prevent SMTP header injection.
   
   Values configured through `setSubject`, `setFrom`, `setTo`, `setCc`, and 
`setBcc` previously allowed embedded CR/LF characters to flow into SMTP header 
construction unchanged. Since SMTP headers are CRLF-delimited, this allowed 
injection of additional headers such as `Bcc:`.
   
   The fix introduces centralized CR/LF stripping in the public setters and 
emits a warning when sanitization occurs.
   
   ## Tests
   
   Added regression tests covering:
   
   * Subject CRLF sanitization
   * Address-field CRLF sanitization
   * Preservation of valid non-malicious input
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to