ramanathan1504 commented on PR #4125:
URL: https://github.com/apache/logging-log4j2/pull/4125#issuecomment-4484431896
**Hi @SebTardif ,**
Thank you so much for your patience and for contributing to this! We really
appreciate the time and effort you've put into getting this `KafkaAppender`
issue resolved. The code changes look good and the review is cleared!
Before we can finally merge this, there are just a few quick administrative
things we need to address:
* **Avoid Force-Pushing during reviews:** I noticed that the recent
updates were force-pushed. For future PRs, please just push new commits
normally rather than force-pushing. Force-pushing overwrites the Git history,
which makes it very difficult for reviewers to track the differences between
the old and new changes.
* **Commit Signatures:** It looks like your commits are currently signed
with a self-signed key. For security and verification purposes, we require
commits to be signed off using a valid **GPG key**. Could you please set up a
GPG key, re-sign your commits, and update the PR?
* **Add a Changelog Entry:** Please add an entry to our changelog file for
this fix. You can use this exact wording:
> *"Fixed an issue where `KafkaAppender` incorrectly reported an error
to the error handler despite a successful retry."*
**Next Steps:**
Since you need to re-sign your previous commits and add the changelog, you
will actually need to force-push **one last time** to update this PR. Once
you've added the changelog and signed with a GPG key, go ahead and push it up,
and we'll get this merged!
Thanks again for your great work on this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
