swebb2066 commented on PR #665: URL: https://github.com/apache/logging-log4cxx/pull/665#issuecomment-4494782404
As the failing tests show, this PR breaks existing code that expects trailing non-digits to terminate an integer. I do not believe this PR adds any value to the code base, especially given that `OptionConverter::toInt` is available for cases where trailing characters are an error. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
