vy commented on code in PR #4111: URL: https://github.com/apache/logging-log4j2/pull/4111#discussion_r3280613218
########## src/changelog/.2.x.x/3926_revamp_list_appender.xml: ########## @@ -0,0 +1,16 @@ +<?xml version="1.0" encoding="UTF-8"?> +<entry xmlns="https://logging.apache.org/xml/ns"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation=" + https://logging.apache.org/xml/ns + https://logging.apache.org/xml/ns/log4j-changelog-0.xsd"; + type="changed"> + <issue id="3926" link="https://github.com/apache/logging-log4j2/pull/3926"/> + <description format="asciidoc"> + Revamped `ListAppender` for thread-safety and clarity: + removed `Collections.synchronizedList` wrappers and replaced with `synchronized` on all public methods, + replaced `Awaitility` polling in `getMessages(int, long, TimeUnit)` with `Object#wait` / `notifyAll`, + improved class and `countDownLatch` Javadoc, + and added unit and concurrency tests. Review Comment: No need this much of elaboration. Remember that this will eventually end up in release notes, which are read by human. ```suggestion Revamp `ListAppender` for thread-safety and clarity. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
