ramanathan1504 commented on PR #4124: URL: https://github.com/apache/logging-log4j2/pull/4124#issuecomment-4511083841
> > Added defensive LinkageError handling in DisruptorUtil when creating async logger exception handlers. > > I don't see that. > > > Guarded sequenceCallback.set(sequence) with a null check in RingBufferLogEventHandler4 to prevent NPE when callback is not initialized. > > I don't see that either. Forgot to mention this earlier @vy — for this PR, @ppkarwasz suggested that we do not need additional LinkageError handling here, since Log4j is already designed to handle it during the initialization stage. The main goal is just to provide better visibility to the user about what is happening. That’s why I reverted the extra LinkageError handling from the earlier commit and only kept the logging message improvement. https://github.com/apache/logging-log4j2/pull/4124/changes/dc9f81f979dcca0dcc8bd41969d233844985b4b8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
