ppkarwasz commented on code in PR #4049:
URL: https://github.com/apache/logging-log4j2/pull/4049#discussion_r3316088371
##########
log4j-core/src/main/java/org/apache/logging/log4j/core/pattern/ThrowableExtendedStackTraceRenderer.java:
##########
@@ -181,7 +181,7 @@ private static Class<?> loadClass(final ClassLoader loader,
final String classNa
if (clazz != null) {
return clazz;
}
- } catch (final Exception ignored) {
+ } catch (final Throwable ignored) {
Review Comment:
Catching `Throwable` might be excessive, let's limit ourselves to
`LinkageError`.
```suggestion
} catch (final Exception | LinkageError ignored) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
