vy commented on code in PR #4130:
URL: https://github.com/apache/logging-log4j2/pull/4130#discussion_r3361508665
##########
src/site/antora/modules/ROOT/pages/manual/pattern-layout.adoc:
##########
@@ -389,8 +389,14 @@ Outputs the instant of the log event
.link:../javadoc/log4j-core/org/apache/logging/log4j/core/pattern/DatePatternConverter.html[`DatePatternConverter`]
specifier grammar
[source,text]
----
-d{pattern}[{timezone}]
-date{pattern}[{timezone}]
+d{pattern}
+d{pattern}{timezone}
+d{pattern}{locale}
+d{pattern}{timezone}{locale}
+date{pattern}
+date{pattern}{timezone}
+date{pattern}{locale}
+date{pattern}{timezone}{locale}
Review Comment:
@ramanathan1504, we better fix the documentation, instead of updating the
parser to accept arguments that can either be a time-zone or locale. That is,
can you revert code changes, and update the documentation to state that we only
support following formats:
```suggestion
d{pattern}
d{pattern}{timezone}
d{pattern}{timezone}{locale}
date{pattern}
date{pattern}{timezone}
date{pattern}{timezone}{locale}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
