sahvx655-wq opened a new pull request, #715: URL: https://github.com/apache/logging-log4cxx/pull/715
GZCompressAction::execute currently waits for the spawned gzip process using apr_proc_wait, but discards the child process exit status by passing NULL for the exit code parameter. As a result, failures from the compression process are not explicitly detected before execution continues. This behavior differs from ZipCompressAction::execute, which retrieves and validates the child process exit status. This patch updates GZCompressAction::execute to capture the exit status returned by apr_proc_wait and validate it before proceeding, aligning its behavior with the existing implementation in ZipCompressAction. Impact Improves error handling consistency for compression actions and ensures that gzip process failures are not silently ignored. Proposed Changes Retrieve the child process exit status in GZCompressAction::execute. Validate the returned exit status before continuing. Align gzip compression handling with the existing ZipCompressAction implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
