ppkarwasz commented on PR #4158: URL: https://github.com/apache/logging-log4j2/pull/4158#issuecomment-4811589133
The `Simplify XInclude enablement` commit (b75050644662d12a7b6b2cf919e7dc3de6fdc909)drops the defensive workaround for [LOG4J2-3531](https://issues.apache.org/jira/browse/LOG4J2-3531) (set `setXIncludeAware(true)`, build a throwaway `DocumentBuilder` to probe support, and silently fall back to `setXIncludeAware(false)` when the parser rejects it). Now that XInclude is opt-in, that dance is no longer needed: if a user's JAXP parser does not support XInclude, they simply don't enable `log4j2.configurationEnableXInclude`. So we set `setXIncludeAware(true)` directly and let an unsupported parser surface the error, instead of degrading to a silent no-op. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
